This repository was archived by the owner on Feb 1, 2022. It is now read-only.
Conversation
hnrch02
force-pushed
the
cli-support-stdin
branch
from
8aad34c to
8f9f33c
Compare
src/cli.js
Outdated
Collaborator
There was a problem hiding this comment.
Perhaps buildReporter('<stdin>') to clarify it's not a normal file?
hnrch02
force-pushed
the
cli-support-stdin
branch
from
8f9f33c to
b1de39f
Compare
Collaborator
|
Is there really a use case for |
Collaborator
Author
|
I don't know just wanted to make it as versatile as possible. |
Collaborator
|
Anyway, I agree with the basic idea and have no objection to using promises. |
Collaborator
Author
|
Great, so LGTY then? |
Collaborator
|
Yeah, sure. |
hnrch02
force-pushed
the
cli-support-stdin
branch
from
b1de39f to
3d5bc67
Compare
Collaborator
|
|
?
Collaborator
|
@hnrch02 |
hnrch02
force-pushed
the
cli-support-stdin
branch
from
3d5bc67 to
12124c2
Compare
hnrch02
added a commit
that referenced
this pull request
Dec 18, 2014
Add support for linting stdin to CLI
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @cvrebert