Skip to content
This repository was archived by the owner on Feb 1, 2022. It is now read-only.

Check for invalid uses of .form-control#263

Merged
cvrebert merged 1 commit intomasterfrom
fix-262
Mar 23, 2015
Merged

Check for invalid uses of .form-control#263
cvrebert merged 1 commit intomasterfrom
fix-262

Conversation

@cvrebert
Copy link
Copy Markdown
Collaborator

Fixes #262.
CC: @hnrch02 for review

@cvrebert cvrebert added this to the v0.13.0 milestone Mar 22, 2015
src/bootlint.js Outdated
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't $('.form-control:not(input, textarea, select)') also work?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, I always forget that that works. Let me change it then.
(There are a few other lint checks that unnecessarily use multiple :nots too, fyi)

@hnrch02
Copy link
Copy Markdown
Collaborator

hnrch02 commented Mar 22, 2015

Otherwise LGTM.

cvrebert added a commit that referenced this pull request Mar 23, 2015
Check for invalid uses of .form-control
@cvrebert cvrebert merged commit 1de9c75 into master Mar 23, 2015
@cvrebert cvrebert deleted the fix-262 branch March 23, 2015 19:49
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling e0783e5 on fix-262 into 91fd0fa on master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using .form-control on the wrong kind of form control should be an error

3 participants