This repository was archived by the owner on Feb 1, 2022. It is now read-only.
.img-responsive should only be used on <img>s#280
Merged
cvrebert merged 1 commit intotwbs:masterfrom May 18, 2015
Merged
Conversation
Contributor
Author
|
Same as #279, for whatever reason I'm getting errors when I try to add tests |
src/bootlint.js
Outdated
Collaborator
There was a problem hiding this comment.
Should be imgResponsiveNotOnImg instead of this. This is probably the cause of the test failures.
Contributor
Author
There was a problem hiding this comment.
Fixed. It was the lack of a jQuery object as the second argument of reporter which caused it.
Collaborator
|
Could you add a testcase asserting that correct usage of |
Contributor
Author
|
Course. Give me 5–10 min |
Contributor
Author
|
@cvrebert added EDIT: Now with the correct number of expectations... |
[Fixes twbs#277] .img-responsive should only be used on <img>s
cvrebert
added a commit
that referenced
this pull request
May 18, 2015
.img-responsive should only be used on <img>s
Collaborator
|
Thanks! |
Contributor
Author
|
My pleasure. Happy to help out @cvrebert. Thanks for the review and help finding that test issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Fixes #277]
.img-responsiveshould only be used on<img>s