This repository was archived by the owner on Feb 1, 2022. It is now read-only.
Closed
Conversation
Collaborator
|
Again, sorry about the delay. |
Collaborator
|
Apparently I neglected to add a wiki page for this. Wrote one just now: https://github.com/twbs/bootlint/wiki/W016 |
Member
|
@cvrebert the wiki entry LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #293
W006 causes some conflicts here in the unit tests because on-disabled-elems.html specifically puts
.disabledon button elements, so they also now report this new warning about.disabledon a<button>.In nodeunit, I can just pass
['W006']and['W016'](the new warning for this one) as disabledIds in each respective unit test, but disabledIds weren't set up for qunit, so I addeddata-disabledas an attribute.This isn't a case that comes up often, so maybe there's a better approach here. Maybe this is overkill and we simply remove the two lines from on-disabled-elems.html that use buttons. Thoughts?
cc @cvrebert @hnrch02 for review.