Remove incorrect aria-haspopup from dropdown toggles#28299
Merged
Conversation
Johann-S
approved these changes
Feb 18, 2019
XhmikosR
previously requested changes
Feb 18, 2019
Member
XhmikosR
left a comment
XhmikosR
left a comment
There was a problem hiding this comment.
blocking until we sort the branches
`aria-haspopup` use requires the use of an ARIA `menu`, `listbox`, `tree`, `grid` or `dialog` (see https://www.w3.org/TR/wai-aria-1.1/#aria-haspopup) in our use (as generic disclosure widgets), it's incorrect and sets up the wrong assumption/behavior from assistive technologies. in future, we likely want to change our dropdowns to essentially be like a `dialog` - move focus to it when opened, possibly make it modal so focus is maintained inside it and the rest of the page is hidden/inert. but for now, removing the incorrect attribute is probably the quickest, most immediate fix.
XhmikosR
force-pushed
the
patrickhlauke-v4-ariahaspopup
branch
from
0efe2e5 to
3600420
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aria-haspopupuse requires the use of an ARIAmenu,listbox,tree,gridordialog(see https://www.w3.org/TR/wai-aria-1.1/#aria-haspopup)in our use (as generic disclosure widgets), it's incorrect and sets up the wrong assumption/behavior from assistive technologies.
in future, we likely want to change our dropdowns to essentially be like a
dialog- move focus to it when opened, possibly make it modal so focus is maintained inside it and the rest of the pageis hidden/inert.
but for now, removing the incorrect attribute is probably the quickest, most immediate fix.
Closes #28295