browsers-devices.md: escape what we read.#28486
Closed
Conversation
It just isn't of any real use for me. Whoever wants to block GA locally, they can do it on their side.
mdo
requested changes
Mar 14, 2019
Member
mdo
left a comment
mdo
left a comment
There was a problem hiding this comment.
Why are we reverting the GA exclusion here? We just approved and merged that change.
Member
Author
|
Because it introduces a JS error locally, and TBH I find this change useless myself. |
Member
I don't see an error on my local dev for |
Member
Author
|
It does introduce a JS error. Try clicking on the themes navbar link for example.
|
This was referenced Mar 14, 2019
Merged
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.