Skip to content

Add ARIA search landmark to documentation.#28983

Merged
XhmikosR merged 1 commit intomasterfrom
bardiharborow-aria-search
Jul 2, 2019
Merged

Add ARIA search landmark to documentation.#28983
XhmikosR merged 1 commit intomasterfrom
bardiharborow-aria-search

Conversation

@bardiharborow
Copy link
Member

@bardiharborow bardiharborow commented Jul 2, 2019

Reference: WAI-ARIA Authoring Practices 1.1 § 4.3.8.

Addendum: .bd-sidebar and bd-toc don't appear to have enough roles, but I'm new at this whole ARIA thing so would prefer advice on this one.

@patrickhlauke
Copy link
Member

i'd say .bd-toc is fine as is. .bd-sidebar probably can be seen as a navigation, but so does the stuff in the header...when you then have more than two containers acting as navigation, they need to be disambiguated with some form of label/name (e.g. an aria-label) so it's clear what the difference is (like "general site navigation" and "documentation navigation" or similar). draft some PR up and we can workshop it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants