Remove attribute selectors from buttons#28988
Merged
Conversation
ysds
approved these changes
Jul 4, 2019
mdo
approved these changes
Jul 10, 2019
Member
mdo
left a comment
mdo
left a comment
There was a problem hiding this comment.
I feel like this had something to do with Normalize back in the day, but I don’t see anything relevant there still today, so likely safe to remove.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We needed this, back in the days when this was still present in our code (see #4666):
bootstrap/less/forms.less
Lines 102 to 108 in fd49d4a
But nowadays it's redundant.