Skip to content

Add support and docs for color input#29059

Merged
XhmikosR merged 5 commits intomasterfrom
color-input
Aug 23, 2019
Merged

Add support and docs for color input#29059
XhmikosR merged 5 commits intomasterfrom
color-input

Conversation

@mdo
Copy link
Member

@mdo mdo commented Jul 16, 2019

As shown in Safari:

Screen Shot 2019-07-16 at 3 22 15 PM

  • Add new .form-control-color modifier class to limit the width
  • Add basic code example
  • Document styling details, browser support, etc

/cc @twbs/css-review

Preview: https://deploy-preview-29059--twbs-bootstrap.netlify.com/docs/4.3/forms/form-control/#color

@mdo mdo marked this pull request as ready for review August 15, 2019 21:17
@mdo mdo requested review from a team as code owners August 15, 2019 21:17
@XhmikosR
Copy link
Member

Perhaps we shouldn't document browser support? I mean, we'd need to cover macOS, Linux and Windows for each of the browsers.

@MartijnCuppens
Copy link
Member

I 've added rounded corners to the swatches and fixed the paddings in Firefox. I've also added the a fix which removes padding from webkit browsers in reboot.

@XhmikosR
Copy link
Member

XhmikosR commented Aug 17, 2019

Should we add cursor pointer?

Or a title or something. I feel like it's not clear one can interact with it.

@MartijnCuppens
Copy link
Member

Yeah, that might be a good idea. Shall we add it with the $enable-pointer-cursor-for-buttons variable?

cursor: if($enable-pointer-cursor-for-buttons, pointer, null);

@XhmikosR
Copy link
Member

Should we add cursor pointer?
Or a title or something. I feel like it's not clear one can interact with it.

@patrickhlauke: what do you think about this?

@MartijnCuppens
Copy link
Member

Btw, I don't think we need to document what the color picker will look like, browsers might change this anytime.

I would add something about browser support (IE) though.

@XhmikosR
Copy link
Member

I definitely agree with the above. See #29059 (comment)

@MartijnCuppens
Copy link
Member

Ok, I've changed the copy to a notice about IE not supporting color inputs.

@XhmikosR XhmikosR merged commit d9abb8e into master Aug 23, 2019
@XhmikosR XhmikosR deleted the color-input branch August 23, 2019 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants