Conversation
|
Nice work! very interesting @ysds 👍 |
31560ae to
a8a764f
Compare
|
Added a demo to the PR's description 😄 |
|
Big fan of abstracting the transitions. I've long wanted to add more transitions to different elements (grow or scale, slide in different directions, etc). |
a8a764f to
9690271
Compare
|
@ysds, any progress on this? |
2bd60ec to
8c21140
Compare
|
I need help from @twbs/js-review because I'm not expert about JavaScript to apply this change to all components and the related tests correctly. It would be great if anyone could take over this PR. And what I am wondering is to use a common class (e.g. |
The common classes feel like a better idea, these classes can than be used by multiple components. |
037831d to
b3ad803
Compare
|
Closing as stale. |
This is an experimental PR for #28968.
This allows more control over CSS classes to achieve flexible CSS Transitions. The following GIF shows two transition patterns:
fade-xxxclasses: fadeIn/Outslide-down-xxxclasses: slideDown/UpAlso you can use your custom transition name (
my-custom-transition-xxxx)Demo: https://codepen.io/anon/pen/dxYqYz?editors=1111