Skip to content

[WIP] Flexible CSS transition control#29081

Closed
ysds wants to merge 7 commits intomainfrom
master-ysds-flexible-transition
Closed

[WIP] Flexible CSS transition control#29081
ysds wants to merge 7 commits intomainfrom
master-ysds-flexible-transition

Conversation

@ysds
Copy link
Contributor

@ysds ysds commented Jul 19, 2019

This is an experimental PR for #28968.

This allows more control over CSS classes to achieve flexible CSS Transitions. The following GIF shows two transition patterns:

  • fade-xxx classes: fadeIn/Out
  • slide-down-xxx classes: slideDown/Up

Also you can use your custom transition name (my-custom-transition-xxxx)

transition

Demo: https://codepen.io/anon/pen/dxYqYz?editors=1111

  • Dropdown
  • Modal
  • Popover
  • Toast
  • Tooltip
  • Unit test

@ysds ysds requested review from a team as code owners July 19, 2019 21:07
@Johann-S
Copy link
Member

Nice work! very interesting @ysds 👍

@ysds ysds force-pushed the master-ysds-flexible-transition branch from 31560ae to a8a764f Compare July 22, 2019 15:12
@ysds
Copy link
Contributor Author

ysds commented Jul 22, 2019

Added a demo to the PR's description 😄

@mdo
Copy link
Member

mdo commented Jul 23, 2019

Big fan of abstracting the transitions. I've long wanted to add more transitions to different elements (grow or scale, slide in different directions, etc).

@ysds ysds force-pushed the master-ysds-flexible-transition branch from a8a764f to 9690271 Compare July 23, 2019 15:02
@MartijnCuppens
Copy link
Member

@ysds, any progress on this?

@ysds
Copy link
Contributor Author

ysds commented Feb 9, 2020

I need help from @twbs/js-review because I'm not expert about JavaScript to apply this change to all components and the related tests correctly. It would be great if anyone could take over this PR.

And what I am wondering is to use a common class (e.g. fade-enter) or a component-specific class (e.g. modal-enter) as the default transition class name.

@MartijnCuppens
Copy link
Member

And what I am wondering is to use a common class (e.g. fade-enter) or a component-specific class (e.g. modal-enter) as the default transition class name.

The common classes feel like a better idea, these classes can than be used by multiple components.

@ysds ysds force-pushed the master-ysds-flexible-transition branch from 037831d to b3ad803 Compare February 26, 2020 01:08
@ysds ysds added the js label Mar 18, 2020
@mdo mdo changed the base branch from master to main June 16, 2020 20:16
@ysds ysds marked this pull request as draft June 25, 2020 16:17
@mdo
Copy link
Member

mdo commented Jan 10, 2021

Closing as stale.

@mdo mdo closed this Jan 10, 2021
@XhmikosR XhmikosR deleted the master-ysds-flexible-transition branch January 14, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants