Merged
Conversation
* Remove about generated button of file form * Remove and merge layout examples of custom forms * Clarify id/for * Change some spacing classes for consistency
mdo
reviewed
Jul 24, 2019
Member
mdo
left a comment
mdo
left a comment
There was a problem hiding this comment.
Looks good overall, just one question.
scss/_variables.scss
Outdated
| $form-range-thumb-focus-box-shadow-width: $input-focus-width !default; // For focus box shadow issue in IE/Edge | ||
| $form-range-thumb-active-bg: lighten($component-active-bg, 35%) !default; | ||
| $form-range-thumb-disabled-bg: $gray-500 !default; | ||
| $form-range-thumb-transition: background-color .15s ease-in-out, border-color .15s ease-in-out, box-shadow .15s ease-in-out !default; |
Member
There was a problem hiding this comment.
Should we make this available to all other forms like checks/radios?
Contributor
Author
There was a problem hiding this comment.
Yep! I was aware of that when I saw the TODO comment in the _form-check.scss, but I prioritize removing "custom" in this PR.
mdo
approved these changes
Jul 25, 2019
Member
mdo
left a comment
mdo
left a comment
There was a problem hiding this comment.
Reminds me I need to review the form layout options alongside the grid ideas from @MartijnCuppens.
MartijnCuppens
approved these changes
Jul 25, 2019
Member
MartijnCuppens
left a comment
MartijnCuppens
left a comment
There was a problem hiding this comment.
Yeah, gonna update the grid PR one of these days since the forms update in now merged. Anyway, this LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.