Conversation
- _navbar.scss for all main navbar code - new _subnav.scss to move all subnav styles into
Member
|
The white on purple contrast looks ok: But the |
MartijnCuppens
approved these changes
Jul 25, 2019
Member
MartijnCuppens
left a comment
MartijnCuppens
left a comment
There was a problem hiding this comment.
The color contrast looks ok now: https://webaim.org/resources/contrastchecker/?fcolor=ECE7F4&bcolor=7952B3
Also, removing the alignment of the sidebar looks ok now.
XhmikosR
force-pushed
the
docs-nav-updates
branch
from
73feed9 to
290fed2
Compare
XhmikosR
approved these changes
Jul 25, 2019
Member
|
Actually, there's just one small issue: the hover color on the sidebar links looks bad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_subnav.scss_nav.scssto_navbar.scssfor docs stylesheightandoverflow-yfor sidebar scrolling@XhmikosR Didn't want to push to your docs PR, but if you want, I can
cherry-pickand move it over.