Skip to content

Remove unneeded Stylelint suppressions.#29222

Merged
XhmikosR merged 2 commits intomasterfrom
master-xmr-stylelint
Aug 7, 2019
Merged

Remove unneeded Stylelint suppressions.#29222
XhmikosR merged 2 commits intomasterfrom
master-xmr-stylelint

Conversation

@XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Aug 7, 2019

Found with --report-needless-disables. Not sure if we should add this yet.

@XhmikosR XhmikosR force-pushed the master-xmr-stylelint branch from 6e3d570 to ae43132 Compare August 7, 2019 12:17
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--report-needless-disables might be useful to add indeed

@XhmikosR
Copy link
Member Author

XhmikosR commented Aug 7, 2019

My main problem with this switch is

  1. it doesn't say which disable rule is redundant
  2. with caching locally this can cause issues when changing the inline suppressions. CI will fail properly though

@XhmikosR XhmikosR merged commit ecaefed into master Aug 7, 2019
@XhmikosR XhmikosR deleted the master-xmr-stylelint branch August 7, 2019 14:26
@MartijnCuppens
Copy link
Member

Hmm, leave it for now then

lucanos pushed a commit to lucanos/bootstrap that referenced this pull request Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants