Skip to content

Remove the jasmine-core devDependency.#29967

Merged
XhmikosR merged 2 commits intomasterfrom
master-xmr-rm-jasmine-core
Jan 7, 2020
Merged

Remove the jasmine-core devDependency.#29967
XhmikosR merged 2 commits intomasterfrom
master-xmr-rm-jasmine-core

Conversation

@XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Jan 7, 2020

karma-jasmine already depends on jasmine-core.

karma-jasmine already depends on jasmine-core.
@Johann-S
Copy link
Member

Johann-S commented Jan 7, 2020

You're right 👍

@XhmikosR XhmikosR merged commit 01ba563 into master Jan 7, 2020
@XhmikosR XhmikosR deleted the master-xmr-rm-jasmine-core branch January 7, 2020 20:18
@ghost
Copy link

ghost commented Jan 23, 2020

I now get a warning on karma-jasmine-html-reporter having a non met jasmine-core dependency.

@XhmikosR
Copy link
Member Author

It's something on your side, there's nothing wrong with this change.

@ghost
Copy link

ghost commented Jan 23, 2020

indeed I was using yarn.
yarn install seems to display some warnings that I don't see with npm.

@XhmikosR
Copy link
Member Author

Since karma-jasmine depends on jasmine-core, it's redundant to have jasmine-core in the devDependencies, which is what this patch was about.

I don't use yarn or any other package managers, nor do we test them on CI.

@ghost
Copy link

ghost commented Jan 23, 2020

I totally get the dep removal, no prb with that, it makes total sense.
I was trying to catch up with the last 100 commits you did since October and noticed this change, that's all.

olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
karma-jasmine already depends on jasmine-core.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants