Remove the jasmine-core devDependency.#29967
Merged
Conversation
karma-jasmine already depends on jasmine-core.
Member
|
You're right 👍 |
Johann-S
approved these changes
Jan 7, 2020
|
I now get a warning on karma-jasmine-html-reporter having a non met jasmine-core dependency. |
Member
Author
|
It's something on your side, there's nothing wrong with this change. |
|
indeed I was using yarn. |
Member
Author
|
Since karma-jasmine depends on jasmine-core, it's redundant to have jasmine-core in the devDependencies, which is what this patch was about. I don't use yarn or any other package managers, nor do we test them on CI. |
|
I totally get the dep removal, no prb with that, it makes total sense. |
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
karma-jasmine already depends on jasmine-core.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
karma-jasmine already depends on jasmine-core.