Use embedded SVGs for carousel icons#30268
Conversation
|
My main concern with this is that the SVGs shouldn't be in the docs since we don't distribute the docs. |
From my perspective, the SVGs are just markup that are needed to make the carousel work. |
I agree, but people might argue that the SVGs should be included. I'm not against this, obviously, just trying to think what issues we might face.
Not sure about this right now, I'll need to play with it and see, because using |
|
About markup VS distribution, just a reminder that for now our close button is text-based and thus requires to get the markup. I think it's the same. Apart from that, it'd be very easy to make SVGs downloadable from the docs without distributing them in our package: might be another way around this. |
|
Closing for #31650. |
Part of #30052.
@XhmikosR, do you know a way to easily indent the svgs in the example code?