Closed
Conversation
XhmikosR
approved these changes
Mar 17, 2020
Member
|
The test failures are unrelated to this PR; I have seen them in the past, I even tried using Ruby 2.6 on CU but I still got similar errors. I'll check tomorrow if there are any gem updates and make a v4-dev PR to update gems and deps. |
MartijnCuppens
approved these changes
Mar 18, 2020
Member
MartijnCuppens
left a comment
MartijnCuppens
left a comment
There was a problem hiding this comment.
LGTM but we also need to add this in master
Member
If so, we should first target master and cherry pick the patch to v4-dev later. |
Member
|
I made #30416 which I plan to cherry pick later in v4-dev and close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30366.