Skip to content

Cleanup responsive tables#30482

Merged
MartijnCuppens merged 1 commit intomasterfrom
master-mc-responsive-tables-cleanup
Mar 31, 2020
Merged

Cleanup responsive tables#30482
MartijnCuppens merged 1 commit intomasterfrom
master-mc-responsive-tables-cleanup

Conversation

@MartijnCuppens
Copy link
Member

@MartijnCuppens MartijnCuppens commented Mar 31, 2020 •
edited
Loading

In #25058, the .table-reponsive class was moved from the table to a wrapper div.

  • display: block; and width: 100%; have become redundant since the wrapper is a div
  • The double border fix isn't needed either since the table keeps its display value
  • I've also simplified the Sass class concatenation.

https://deploy-preview-30482--twbs-bootstrap.netlify.com/docs/4.3/content/tables/#breakpoint-specific

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner March 31, 2020 07:34
ffoodd
ffoodd approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@MartijnCuppens MartijnCuppens merged commit 22a5356 into master Mar 31, 2020
@MartijnCuppens MartijnCuppens deleted the master-mc-responsive-tables-cleanup branch March 31, 2020 08:33
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@MartijnCuppens @olsza
Cleanup responsive tables (twbs#30482)
77c3ed8
@anoadragon453 anoadragon453 mentioned this pull request Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ffoodd ffoodd ffoodd approved these changes

Assignees

No one assigned

Labels

css no-backport-to-v4 v5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MartijnCuppens @ffoodd