Skip to content

Misaligned close button in toasts examples#30532

Closed
ffoodd wants to merge 1 commit intomasterfrom
master-fod-docs-toasts-alignment
Closed

Misaligned close button in toasts examples#30532
ffoodd wants to merge 1 commit intomasterfrom
master-fod-docs-toasts-alignment

Conversation

@ffoodd
Copy link
Member

@ffoodd ffoodd commented Apr 8, 2020

@MartijnCuppens
Copy link
Member

I prefer the current implementation:

Current:
image

PR:
image

@ffoodd
Copy link
Member Author

ffoodd commented Apr 8, 2020

Oooh I think I understand what's going on… Might be font related, since I'm on Ubuntu. This is what it looks like on both Chrome and Firefox on Ubuntu:

Master:
Screenshot_2020-04-08 Toasts

This PR:
Screenshot_2020-04-08 Toasts(1)

Removing .mb-1 may not be the answer, but this alignment should probably not depend on font / OS, am I wrong?

@MartijnCuppens
Copy link
Member

MartijnCuppens commented Apr 8, 2020

we should ditch the × in favour of an SVG which is easier to align and style (see #27163)

@ffoodd
Copy link
Member Author

ffoodd commented Apr 8, 2020

Agreed, I need an override in Boosted for now!

I'm closing this.

@ffoodd ffoodd closed this Apr 8, 2020
@XhmikosR XhmikosR deleted the master-fod-docs-toasts-alignment branch April 9, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants