Closed
Conversation
XhmikosR
reviewed
Apr 15, 2020
|
|
||
| ### Buttons | ||
|
|
||
| - Removed `.btn-block` as it duplicated functionality of utilities, but in a more limited way. With a utilities based approach, "block buttons" are now easily made responsive. |
Member
There was a problem hiding this comment.
I think we should mention the exact replacement classes to make things easier for people 🙂
Member
|
I don't think we need the |
Member
Author
|
Might not go this route after all actually... requires more utility classes to undo the responsive blocks (assuming block on mobile, not block on say medium). 🤔 |
Member
Author
|
Closing per my last comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternate fix for #30376, which closes #30223.