Replace double tilde with Math.floor#30691
Merged
Conversation
alecpl
reviewed
Apr 30, 2020
Nowadays browser engines have improved a lot and `Math.floor` is the same if not faster. Also, clarity is better than micro-optimizations in this case.
XhmikosR
force-pushed
the
master-xmr-math-floor
branch
from
ae52f90 to
b3920a8
Compare
Member
Author
|
IE and old Edge do benefit from double tilde. Not that it matters a lot but anyway, I removed the change from 4.4.x. |
mdo
approved these changes
May 14, 2020
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
Nowadays, browser engines have improved a lot and `Math.floor` is the same, if not faster. Also, clarity is better than micro-optimizations in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nowadays, browser engines have improved a lot and
Math.flooris the same, if not faster.Also, clarity is better than micro-optimizations in this case.