Skip to content

Examples: a few fixes#30998

Merged
mdo merged 4 commits intomasterfrom
master-fod-fix-examples
Jun 14, 2020
Merged

Examples: a few fixes#30998
mdo merged 4 commits intomasterfrom
master-fod-fix-examples

Conversation

@ffoodd
Copy link
Member

@ffoodd ffoodd commented Jun 10, 2020

  • Fix Headings hierarchy in Examples list: easy to fix, no drawback
  • Drop redundant alternative on screenshots: block links were labelled like "Album screenshot Album" which is annoying
  • Pricing example layed on .card-deck, which has been dropped in v5.

The first two points could be backported to v4, not quite sure about its usefullness however since those are pretty low priorities— @patrickhlauke, any opinion?

@ffoodd ffoodd requested a review from a team as a code owner June 10, 2020 08:51
@XhmikosR XhmikosR requested a review from patrickhlauke June 12, 2020 08:12
@XhmikosR XhmikosR changed the title Examples : a few fixes Examples: a few fixes Jun 12, 2020
@XhmikosR
Copy link
Member

Not sure about the alt change, the rest look good to me though. @patrickhlauke WDYT?

@mdo mdo merged commit aee711b into master Jun 14, 2020
@mdo mdo deleted the master-fod-fix-examples branch June 14, 2020 21:47
@mdo
Copy link
Member

mdo commented Jun 14, 2020

Merged today to clear out the v5 project as much as possible. Sorry for not waiting, but if there's more, happy to help tackle it in another PR <3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants