Conversation
Member
|
Looks promising, did you checked that override was indeed easier? |
Contributor
|
This change would've been helpful when simply wanting to refer to the existing palette rather than extending the color-map:
So I currently copy the palette which is imported before the overrides, followed by bootstrap/scss/variables. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new Sass partial,
_colors.scss, to help improve the structure of our code base given Sass's limitations around re-assigning variables. This should allow folks to use our own color variables in their customization more easily. Arguably this could be considered a breaking change, so we'll want to be careful about this.TBD if we break out further variables... if we wanted to, some ideas could include:
_settings.scssto house our$enable-options, escaped characters, and variable prefix._grid.scssto house our breakpoints, containers, and more._type.scssfor all typographyNot 100% final on anything, but potentially worth discussing while we're evaluating this.