Fixed components/spinners page link to text alignment utility#34119
Merged
Conversation
ffoodd
approved these changes
May 26, 2021
Contributor
ffoodd
left a comment
ffoodd
left a comment
There was a problem hiding this comment.
Indeed, dist files should not be commited.
Thanks for the PR 👌
alpadev
added
skip-changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34113
Changes
Just a quick link swap in
spinners.md.Description
https://getbootstrap.com/docs/5.0/components/spinners/#placement suggests a link to the text alignment utility; however, the link takes you to https://getbootstrap.com/docs/5.0/content/typography/ instead of https://getbootstrap.com/docs/5.0/utilities/text/.
I already tested it locally with
npm run testandnpm run docs-serveand it works; however, doing so modified somedistfiles shown in the image below which I didn't include in this pull request. Just making sure I can leave it out of the PR?