allow to specify the backdrop parent for the modal component#35634
Closed
allow to specify the backdrop parent for the modal component#35634
Conversation
Member
|
Hello @Johann-S 😃 Can you please help me to understand how can it help Gatsby users? We had another PR trying to introduce a modal option, defining In case I am right and we provide the modal Ps: would appreciate your help/response on #34989 (comment) |
Member
Author
|
Hey :) Finally after some tests on my project, it's because of purgeCSS remove |
Member
|
So, do we need this after all? |
Member
Author
|
Nope I don't think it's useful at all 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everybody!
I hope you're doing well, I wish you the best for this new year!
A small PR, to allow to specify the root element for the modal backdrop, it can be useful for users who use Bootstrap with Gatsby for example
Edit: The build failed on something I didn't changed, that's strange 🤔