Merged
Conversation
…bkit differences in button focus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Popovers initialized via
data-bs-toggle="popover"wouldn't dismiss when you clicked their trigger a second time in Chromium browsers. Safari was fine.The data API shouldn't be duplicating trigger handling —
_setListeners()already handlesclick,focus, andhoverbased on the trigger config.initPopovernow just callsPopover.getOrCreateInstance(target)(pluspreventDefault()on click to preserve the<a href="#">behavior).On a fresh popover the first click still works: the capture-phase document handler creates the instance, which registers the click listener on the element, and the newly-added listener fires in the same dispatch's target phase. No more double-toggle, no more stuck
_activeTrigger.focus.Fixes #42339.