Column-footer aggregates (Sum/Min/Max/Avg) should follow the field's Short/Full format

[1alexandrer]

Scope & Context

Twenty already lets users choose Short ($1.2m) vs Full ($1,200,000) display for Currency fields, and Number vs Short for Number fields, and the table cells honor that. But the column-footer aggregates (Sum / Min / Max / Average), the record-index group totals, and the pie-chart center metric ignore the field's format setting — they all go through transformAggregateRawValueIntoAggregateDisplayValue, which doesn't read the field's settings.

Related to #21521.

Current behavior

A Currency column set to Full shows full amounts in its cells, but its footer Sum (and Min/Max/Avg) still renders the abbreviated value — an inconsistency between the cells and their totals. Same for Number fields set to short.

Expected behavior

Aggregate totals should follow the column field's own Short/Full setting, so the footer/total matches the cells:

• Currency: full when the field's format is full, else short.
• Number: short when the field's type is shortNumber, else full.
• Percentage and COUNT operations are unaffected.

Technical inputs

• Single change in packages/twenty-front/src/modules/object-record/record-aggregate/utils/transformAggregateRawValueIntoAggregateDisplayValue.ts: make the CURRENCY and NUMBER branches read aggregateFieldMetadataItem.settings (mirroring CurrencyDisplay/NumberFieldDisplay).
• No new GraphQL, no migration, no snapshot changes. All three consumers (footer, record-index, pie-center) benefit automatically since they already pass the field metadata.
• Follow-up note: there are currently a few separate "short/full" vocabularies (FieldCurrencyFormat, FieldNumberVariant, graph displayType, widget ChartNumberFormat); a broader unification could be scoped separately.

[sonarly[bot]]

🟡 Sonarly Analysis — Medium Severity

Aggregate formatter ignores currency/number display settings

Aggregate values are formatted with hardcoded rules, so footer/group/chart totals can display differently from table cells for the same field.

Root Cause

transformAggregateRawValueIntoAggregateDisplayValue applies hardcoded formatting for currency and partial formatting for number, instead of mirroring field settings:

• Currency branch always returns short format:
  • return formatToShortNumber(Number(aggregateRawValue) / 1_000_000);
• Number branch handles percentage but not shortNumber:
  • fallback is always formatNumber(...)
    [verified in packages/twenty-front/src/modules/object-record/record-aggregate/utils/transformAggregateRawValueIntoAggregateDisplayValue.ts]

This is inconsistent with row-cell renderers, which do read field settings:

• CurrencyDisplay checks fieldDefinition.metadata.settings?.format and uses short vs full accordingly.
• NumberFieldDisplay checks fieldDefinition.metadata.settings?.type and handles shortNumber.
  [verified in CurrencyDisplay.tsx and NumberFieldDisplay.tsx]

All affected UI surfaces share this same aggregate formatter and already pass field metadata into it (so the problem is not missing inputs):

• table footer hook
• record-index group aggregate hook
• pie-chart center metric hook
  [verified in:
  useAggregateRecordsForRecordTableColumnFooter.tsx,
  useSetRecordIndexAggregateDisplayValueForRecordGroupValue.ts,
  usePieChartCenterMetricData.ts]

Why it failed now (triggering cause):
The bug is latent for default formatting, and becomes visible when users switch field settings away from defaults (Currency full, Number shortNumber). At that point, cells respect settings but aggregates still use hardcoded logic, creating immediate mismatch. This is a data/state-triggered exposure (field setting value), not an infra incident.

Timeline evidence:

• The problematic formatter behavior was introduced when this utility was created in commit 061cc897af... (“Improve record group aggregate query performance”), including tests that codified short currency output ('230.4k') and no shortNumber aggregate case.
• The latest non-blocked maintainer touching this file is d0bc8b9ffe....

Blame commit: d0bc8b9f by bosiraphael — [DASHBOARDS] Move all the graph computing logic to the backend (#17189)

Suggested Fix

Implemented a targeted fix in transformAggregateRawValueIntoAggregateDisplayValue so aggregate formatting now honors the same field display settings as row cells:

1. Currency aggregates now respect settings.format

   • Previous behavior always forced short format (formatToShortNumber).
   • New behavior:
     • format undefined or 'short' -> short format (unchanged default behavior)
     • format === 'full' -> full numeric format via formatNumber, with decimals from settings (fallback to DEFAULT_DECIMAL_VALUE)

2. Number aggregates now respect settings.type === 'shortNumber'

   • Previous behavior handled only 'percentage' and default full number formatting.
   • New behavior adds an explicit 'shortNumber' branch using formatToShortNumber.

3. Added regression tests

   • New test for currency aggregate with format: 'full' and decimals.
   • New test for number aggregate with type: 'shortNumber'.

This keeps formatting logic aligned between aggregate values and record cell rendering, resolving the mismatch users saw when using non-default display settings.

---

Analyzed by Sonarly · View full analysis

[bosiraphael]

@Bonapara do we want this change?