Design fixes on show page #11221
Merged
Design fixes on show page #11221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bosiraphael
commented
Mar 27, 2025
bosiraphael
commented
- Fixes record inline cell height
- Fixes notes body empty state
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
This PR implements design fixes for the show page, focusing on standardizing inline cell heights and improving empty state displays.
- Removed padding-top/bottom (3px each) from
StyledRecordInlineCellNormalModeInnerContainerinRecordInlineCellDisplayMode.tsx - Changed
StyledInlineCellBaseContainerheight from fit-content to fixed values (24px/18px) inRecordInlineCellContainer.tsx - Added
isDisplayModeFixHeight: trueprop toFieldContext.Providercomponents inFieldsCard.tsx - Simplified empty state check for RichTextV2 fields to only validate markdown value in
isFieldValueEmpty.ts
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
...-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellContainer.tsx
Show resolved
Hide resolved
martmull
approved these changes
Mar 27, 2025
charlesBochet
added a commit
that referenced
this pull request
Mar 27, 2025
In this PR: - allow to update settings on fields metadata (regression introduced by a recent refactoring of fields-metadata update) - revert changes introduced by #11221
charlesBochet
added a commit
that referenced
this pull request
Mar 27, 2025
In this PR: - allow to update settings on fields metadata (regression introduced by a recent refactoring of fields-metadata update) - revert changes introduced by #11221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.