Skip to content

Conversation

@thomtrp
Copy link
Contributor

@thomtrp thomtrp commented Mar 27, 2025

  • allow all form fields that may need a placeholder to set it
  • update main icons on versions and runs

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR standardizes form field placeholders and updates workflow-related icons across the Twenty application.

  • Added consistent placeholder support to form field components (FormDateFieldInput, FormLinksFieldInput, FormNumberFieldInput, etc.) with default fallbacks
  • Centralized form field default settings through getDefaultFormFieldSettings utility
  • Changed workflow icons: workflowRun to IconHistoryToggle and workflowVersion to IconVersions for better visual representation
  • Refactored header icon handling to use useRecordShowPage hook instead of prop passing
  • Fixed placeholder handling in WorkflowEditActionFormBuilder with proper null checks and type safety

15 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@martmull martmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomtrp thomtrp merged commit 439ccb0 into main Mar 27, 2025
47 checks passed
@thomtrp thomtrp deleted the tt-workflow-fast-follows branch March 27, 2025 16:01
@sentry
Copy link

sentry bot commented Apr 3, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Workflow is not enabled. If you want to use it, please enable it in the lab. /object/workflow/d25c009a-2dae-499e-83f8-73ea2d... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants