changed template cache names to take into account the Twig C extension#1844
Merged
fabpot merged 1 commit intotwigphp:1.xfrom Sep 24, 2015
Merged
changed template cache names to take into account the Twig C extension#1844fabpot merged 1 commit intotwigphp:1.xfrom
fabpot merged 1 commit intotwigphp:1.xfrom
Conversation
Member
|
👍 |
Contributor
|
👍 apart from the comment. I'd like to propose another PR on top of this when merged. |
fabpot
force-pushed
the
cext-cache-names
branch
from
a3bbfd0 to
76ecd43
Compare
fabpot
added a commit
that referenced
this pull request
Sep 24, 2015
…wig C extension (fabpot) This PR was merged into the 1.x branch. Discussion ---------- changed template cache names to take into account the Twig C extension Commits ------- 76ecd43 changed template cache names to take into account the Twig C extension
Member
|
@fabpot this broke the tests when the C extension is enabled |
Contributor
|
I don't understand why revoking the cache if the C extension is enabled.
Edit: just read the code, the template is effectively different if the C ext is used. |
Contributor
|
The tests are going to be fixed by #1852 |
fabpot
added a commit
that referenced
this pull request
Oct 4, 2015
…isions (Tobion) This PR was merged into the 1.x branch. Discussion ---------- fix template class name generation to prevent possible collisions - fix template class name generation to prevent possible collisions - save one inode per file - fix tests as they are broken with the cext since #1844 Commits ------- f379e81 fix template class name generation to prevent possible collisions and one inode per file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.