Allow null when Twig expects a string#3617
Merged
fabpot merged 1 commit intotwigphp:2.xfrom Jan 2, 2022
Merged
Conversation
This was referenced Jan 2, 2022
ruudk
added a commit
to ruudk/Twig
that referenced
this pull request
Jan 3, 2022
Same as twigphp#3617
Merged
ruudk
added a commit
to ruudk/Twig
that referenced
this pull request
Jan 3, 2022
Same as twigphp#3617
ruudk
added a commit
to ruudk/Twig
that referenced
this pull request
Jan 3, 2022
Same as twigphp#3617
ruudk
added a commit
to ruudk/Twig
that referenced
this pull request
Jan 3, 2022
Same as twigphp#3617
ruudk
added a commit
to ruudk/Twig
that referenced
this pull request
Jan 3, 2022
ruudk
added a commit
to ruudk/Twig
that referenced
this pull request
Jan 3, 2022
la5942
added a commit
to la5942/Twig
that referenced
this pull request
Feb 7, 2023
… subject to result in a non-match. Resolves BC break introduced in PR twigphp#3687 As per pattern in twigphp#3617
fabpot
added a commit
that referenced
this pull request
Feb 8, 2023
…942) This PR was merged into the 3.x branch. Discussion ---------- Restores the leniency of the `matches` twig comparison Restores the leniency of the `matches` twig comparison, allowing null subject to result in a non-match. Resolves BC break introduced in PR #3687 ref in #3801 (comment) As per pattern in #3617 Commits ------- f136668 Restores the leniency of the `matches` twig comparison, allowing null subject to result in a non-match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ease the transition to PHP 8.1, Twig now explicitly accepts
nullin addition to strings in filters that expect strings.Closes #3615
Closes #3557
Closes #3610
Closes #3609