Add return type annotations on Twig 3 to prepare Twig 4#4534
Merged
fabpot merged 1 commit intotwigphp:3.xfrom Jan 24, 2025
Merged
Add return type annotations on Twig 3 to prepare Twig 4#4534fabpot merged 1 commit intotwigphp:3.xfrom
fabpot merged 1 commit intotwigphp:3.xfrom
Conversation
Contributor
Author
|
(fabbot unrelated) |
Contributor
Author
|
(fixed my mistakes, all seems ok now) |
stof
reviewed
Jan 7, 2025
| } | ||
|
|
||
| private function needEscaping() | ||
| private function needEscaping(): string|bool |
Member
There was a problem hiding this comment.
string|false actually. true is not a valid strategy.
Contributor
Author
There was a problem hiding this comment.
"true" will wait Twig4 / PHP 8.2 no ?
Member
There was a problem hiding this comment.
I don't understand what you mean here. true would indeed require PHP 8.2 to be used. But the one we need here is false, not true
Contributor
Author
|
Thank you very much @stof! (and sorry i make that many mistakes 😮💨 ) I've fixed all your comments |
de4dc5e to
82be134
Compare
Contributor
|
Thank you @smnandre. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started to add missing type annotation following @stof comment here.
Update: I checked here every class (but one) in the
srcdirectory.But you should
probablycertainely have another look.Remains:
I'm happy to let them to someone else.... this was less fun than I expected 😅