Skip to content

Fix inconsistent array access with a Stringable key#4822

Merged
fabpot merged 1 commit into
twigphp:3.xfrom
fabpot:fix-stringable-array-key-optimization
May 29, 2026
Merged

Fix inconsistent array access with a Stringable key#4822
fabpot merged 1 commit into
twigphp:3.xfrom
fabpot:fix-stringable-array-key-optimization

Conversation

@fabpot
Copy link
Copy Markdown
Contributor

@fabpot fabpot commented May 29, 2026

Closes #4804

@stof
Copy link
Copy Markdown
Member

stof commented May 29, 2026

@fabpot it would be great to fix the php-cs-fixer config to match the expectation of the codebase, or to fix existing violations if they are not intended, so that the fabbot CI job could be green again.

@fabpot fabpot merged commit 79884de into twigphp:3.x May 29, 2026
39 of 40 checks passed
@fabpot fabpot deleted the fix-stringable-array-key-optimization branch May 29, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

\Stringable when strict_variables: true silently becomes string in array key. When strict_variables: false exception thrown

2 participants