Improve java sdk consistency#5
Merged
koen-serry merged 7 commits intotwikey:masterfrom Jan 19, 2026
Merged
Conversation
chaixdev
commented
Jan 19, 2026
- Centralized Error Handling: Added apiError(HttpResponse<?>) in TwikeyClient to handle both ApiError and apierror headers. This fixed an inconsistency between gateways.
- Robust Null/Blank Handling: Created RequestUtils.putIfNotNull with centralized logic to filter out both null and isBlank() strings. This standardized behavior across all request classes and mitigates a potential bug where blank values were not considered.
- Refactored PaylinkGateway: Brought PaylinkGateway in line with other gateways by introducing PaylinkRequest and PaylinkResponse models. The old method is preserved but @deprecated.
- Modernized Authentication: Migrated getSessionToken() from legacy HttpURLConnection to the modern HttpClient.
- Hmac comparison: replaced manual for loop comparison with more secure MessageDigest.equals()
added 7 commits
January 16, 2026 16:23
210432a to
960d63d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.