fix: update sdk name #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GirtsR
requested changes
Nov 11, 2025
CHANGELOG.md
Outdated
| - Added screenshare functionality on both iOS and Android. Screensharing can be enabled in a room with `toggleScreenSharing(true)` and disabled with `toggleScreenSharing(false)` | ||
| - Added new callbacks **onRoomIsReconnecting** and **onRoomDidReconnect** (Android & iOS) to detect signalling interruptions and successful reconnections. | ||
| - Made **data track optional** on both iOS and Android. Data track now behaves like audio and video tracks: | ||
| - Made **data track optional** on both iOS and Android. Data track now behaves like audio and video tracks. |
There was a problem hiding this comment.
I think it'd be nice to explain what options/methods can be used to control data tracks now (enableData when connecting, setLocalDataTrackEnabled in the room)
GirtsR
requested changes
Nov 12, 2025
CHANGELOG.md
Outdated
| - Added screenshare functionality on both iOS and Android. Screensharing can be enabled in a room with `toggleScreenSharing(true)` and disabled with `toggleScreenSharing(false)` | ||
| - Added new callbacks **onRoomIsReconnecting** and **onRoomDidReconnect** (Android & iOS) to detect signalling interruptions and successful reconnections. | ||
| - Made **data track optional** on both iOS and Android. Data track now behaves like audio and video tracks: | ||
| - Made **data track optional** on both iOS and Android. Data track now behaves like audio and video tracks. |
|
Please update the PR description to reflect the changes that were made. |
|
One more thing: let's add a changelog entry to reflect the change in the npm package name:
|
Co-authored-by: Girts Rudziss <girtsrudziss@gmail.com>
GirtsR
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Contributing to Twilio