feat: allow conference participant to be any endpoint#559
Merged
eshanholtz merged 18 commits intotwilio:mainfrom Apr 23, 2021
Merged
feat: allow conference participant to be any endpoint#559eshanholtz merged 18 commits intotwilio:mainfrom
eshanholtz merged 18 commits intotwilio:mainfrom
Conversation
eshanholtz
reviewed
Aug 4, 2020
src/main/java/com/twilio/rest/api/v2010/account/conference/Participant.java
Show resolved
Hide resolved
Contributor
|
This PR LGTM but requires downstream API changes to autogenerate properly. An internal ticket has been filed against the relevant product team (reference ID: VOICE-6421). I'm going to hold off approving and merging until the upstream changes have been made. |
eshanholtz
added
code-generation
Contributor
|
@JaymoKang please check the license agreement in the checklist. |
Contributor
Author
|
@eshanholtz any updates? |
Contributor
|
Still waiting on the internal ticket. |
Contributor
|
Internal reference ID update: CONF-2813 |
thinkingserious
added
status: code review request
thinkingserious
added
status: work in progress
JaymoKang
commented
Apr 9, 2021
src/main/java/com/twilio/rest/api/v2010/account/conference/Participant.java
Outdated
Show resolved
Hide resolved
eshanholtz
approved these changes
Apr 23, 2021
Contributor
eshanholtz
left a comment
eshanholtz
left a comment
There was a problem hiding this comment.
We received confirmation that this has been fixed on the back end, so I'm going to go ahead and merge this PR. Thank you @JaymoKang for the contribution and your patience getting this merged!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Allows clients and sip to also be conference participants
First time contributing in this repository, I have no idea what I'm doing. Any help is appreciated :)
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.