Skip to content

fix!: replace ICE Server URL properties with String types#587

Merged
childish-sambino merged 1 commit intomainfrom
ice-url-fix
Sep 23, 2020
Merged

fix!: replace ICE Server URL properties with String types#587
childish-sambino merged 1 commit intomainfrom
ice-url-fix

Conversation

@childish-sambino
Copy link
Copy Markdown
Contributor

Developers MUST NOT use a generic hierarchical URI parser to parse a "stun" or "stuns" URI.

Developers MUST NOT use a generic hierarchical URI parser to parse a "turn" or "turns" URI.

Fixes #400

> Developers MUST NOT use a generic hierarchical URI parser to parse a "stun" or "stuns" URI.

> Developers MUST NOT use a generic hierarchical URI parser to parse a "turn" or "turns" URI.
/**
* POJO representation of a Twilio ICE server.
*/
@Data
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@childish-sambino childish-sambino merged commit 880ab24 into main Sep 23, 2020
@childish-sambino childish-sambino deleted the ice-url-fix branch September 23, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect use of java.net.URI for ICE servers

2 participants