Skip to content

chore: disallow Log4j#618

Merged
JenniferMah merged 4 commits intotwilio:mainfrom
sullis:disallow-log4j
Feb 3, 2021
Merged

chore: disallow Log4j#618
JenniferMah merged 4 commits intotwilio:mainfrom
sullis:disallow-log4j

Conversation

@sullis
Copy link
Copy Markdown
Contributor

@sullis sullis commented Jan 30, 2021

Fixes

disallow Log4j v1 and Log4j v2

This library should only use SLF4J logging.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Copy link
Copy Markdown
Contributor

@JenniferMah JenniferMah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @sullis!

@JenniferMah JenniferMah merged commit a76bb9b into twilio:main Feb 3, 2021
@sullis sullis deleted the disallow-log4j branch April 1, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants