chore: protected TwilioRestClient constructor#631
Merged
eshanholtz merged 1 commit intotwilio:mainfrom Apr 12, 2021
bcanseco:patch-1
Merged
chore: protected TwilioRestClient constructor#631eshanholtz merged 1 commit intotwilio:mainfrom bcanseco:patch-1
eshanholtz merged 1 commit intotwilio:mainfrom
bcanseco:patch-1
Conversation
Allows for extending the class.
eshanholtz
approved these changes
Apr 12, 2021
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
This PR changes the access modifier for the TwilioRestClient constructor from
privatetoprotected. Allows for extending the class (e.g. for wrapping thesuper.request()method with instrumentation).Verified that
make testpasses but haven't added any additional tests since it's just a simple access change / would just be testing a core Java feature. Lmk if we do want a test for this and I'd be happy to write something up.Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.