Skip to content

chore: protected TwilioRestClient constructor#631

Merged
eshanholtz merged 1 commit intotwilio:mainfrom
bcanseco:patch-1
Apr 12, 2021
Merged

chore: protected TwilioRestClient constructor#631
eshanholtz merged 1 commit intotwilio:mainfrom
bcanseco:patch-1

Conversation

@bcanseco
Copy link
Copy Markdown
Member

Fixes

This PR changes the access modifier for the TwilioRestClient constructor from private to protected. Allows for extending the class (e.g. for wrapping the super.request() method with instrumentation).

Verified that make test passes but haven't added any additional tests since it's just a simple access change / would just be testing a core Java feature. Lmk if we do want a test for this and I'd be happy to write something up.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@eshanholtz eshanholtz merged commit d3b891f into twilio:main Apr 12, 2021
@bcanseco bcanseco deleted the patch-1 branch April 12, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants