Skip to content

fix: removed noauth flow #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2025
Merged

fix: removed noauth flow #899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e62377a
removed noauth flow
sbansla Sep 18, 2025
cdd3eac
Merge branch '11.0.0-rc' into twilio_rest_client_reuse_change
sbansla Sep 18, 2025
0a20438
added noauth test
sbansla Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 0 additions & 48 deletions src/main/java/com/twilio/TwilioNoAuth.java
View file
Open in desktop

This file was deleted.

17 changes: 16 additions & 1 deletion src/main/java/com/twilio/auth_strategy/NoAuthStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,24 @@

import com.twilio.constant.EnumConstants;

// Does not have any state thus thread safe.
public class NoAuthStrategy extends AuthStrategy {
private static volatile NoAuthStrategy INSTANCE;

public NoAuthStrategy(String token) {
private static volatile NoAuthStrategy instance;

public static NoAuthStrategy getInstance() {
if (instance == null) {
synchronized (NoAuthStrategy.class) {
if (instance == null) {
instance = new NoAuthStrategy();
}
}
}
return instance;
}

private NoAuthStrategy() {
super(EnumConstants.AuthType.NO_AUTH);
}

Expand Down
51 changes: 0 additions & 51 deletions src/main/java/com/twilio/base/noauth/Creator.java
View file
Open in desktop

This file was deleted.

51 changes: 0 additions & 51 deletions src/main/java/com/twilio/base/noauth/Deleter.java
View file
Open in desktop

This file was deleted.

52 changes: 0 additions & 52 deletions src/main/java/com/twilio/base/noauth/Fetcher.java
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions src/main/java/com/twilio/base/noauth/Resource.java
View file
Open in desktop

This file was deleted.

51 changes: 0 additions & 51 deletions src/main/java/com/twilio/base/noauth/Updater.java
View file
Open in desktop

This file was deleted.

11 changes: 7 additions & 4 deletions src/main/java/com/twilio/http/TwilioRestClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,13 @@ protected TwilioRestClient(Builder b) {
* @return Response object
*/
public Response request(final Request request) {
if (username != null && password != null) {
request.setAuth(username, password);
} else if (authStrategy != null) {
request.setAuth(authStrategy);
// If authStrategy is passed from NoAuth API, no need to set authStrategy (ex TokenCreator).
if (request.getAuthStrategy() == null) {
if (username != null && password != null) {
request.setAuth(username, password);
} else if (authStrategy != null) {
request.setAuth(authStrategy);
}
}

if (region != null)
Expand Down
Loading