fix: Regional API domain processing #895
Conversation
There was a problem hiding this comment.
Pull request overview
This PR attempts to introduce regional API domain processing by adding a region_mappings dictionary and deprecating the edge parameter in favor of region. However, the implementation has several critical issues that will break existing functionality and violate the documented API contract.
Key changes attempted:
- Added
region_mappingsdictionary to map region codes (e.g., "au1") to edge names (e.g., "sydney") - Added deprecation warning for the
edgeparameter - Modified edge initialization logic to automatically derive edge from region
- Added test for deprecation warning
- Updated test cases to use mapped region values
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| twilio/base/client_base.py | Adds region-to-edge mapping dictionary, deprecation warning for edge parameter, and modified initialization logic (contains critical bugs) |
| tests/unit/rest/test_client.py | Adds deprecation warning test and updates test values to use region codes (contains unused import) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
twilio/base/client_base.py
Outdated
| "`edge` is deprecated and will be removed in a future version. Use `region` instead.", | ||
| DeprecationWarning | ||
| ) | ||
| self.edge = (self.region_mappings[region] if region is not None else "") or edge or environment.get("TWILIO_EDGE") |
There was a problem hiding this comment.
If region and edge both are provided, it will default to the edge specified in our mapping. Instead, it should give priority to the edge provided by the customer
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Fixes
Set Deprecation warning for edge
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.