fix(http): fall back to self.timeout in AsyncTwilioHttpClient.request#928
Open
nileshpatil6 wants to merge 1 commit into
Open
fix(http): fall back to self.timeout in AsyncTwilioHttpClient.request#928nileshpatil6 wants to merge 1 commit into
nileshpatil6 wants to merge 1 commit into
Conversation
When the timeout argument is None, AsyncTwilioHttpClient.request did not fall back to self.timeout, unlike the sync TwilioHttpClient. This meant the timeout configured on the client had no effect in async usage. Match the sync behavior: if timeout is None, use self.timeout. Fixes twilio#925 Signed-off-by: nileshpatil6 <technil6436@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #925
AsyncTwilioHttpClient.requestdid not useself.timeoutwhen thetimeoutparameter wasNone, unlike the syncTwilioHttpClient. The timeout set on the client was silently ignored in async usage.Match the sync behavior: fall back to
self.timeoutwhentimeoutisNone.Before:
After: