Conversation
walro
reviewed
Nov 20, 2020
Pontus4
force-pushed
the
optional-logger
branch
from
625998e to
a7d3d7e
Compare
walro
reviewed
Nov 20, 2020
roback
reviewed
Nov 24, 2020
Pontus4
force-pushed
the
optional-logger
branch
from
a7d3d7e to
79ddb53
Compare
Pontus4
commented
Nov 30, 2020
Pontus4
force-pushed
the
optional-logger
branch
from
79ddb53 to
814f1e2
Compare
walro
reviewed
Nov 30, 2020
Pontus4
force-pushed
the
optional-logger
branch
from
814f1e2 to
96fef07
Compare
Pontus4
commented
Dec 1, 2020
Pontus4
force-pushed
the
optional-logger
branch
from
96fef07 to
e9c152b
Compare
Closed
walro
reviewed
Dec 1, 2020
Pontus4
force-pushed
the
optional-logger
branch
from
e9c152b to
7dafb8e
Compare
walro
reviewed
Dec 1, 2020
...and add corresponding spec Close #9
...since it is not needed.
Pontus4
force-pushed
the
optional-logger
branch
from
7dafb8e to
16c5e26
Compare
Pontus4
added a commit
that referenced
this pull request
Jun 15, 2021
Got the following error in twingly/basil#78: ``` gems/twingly-http-0.3.1/lib/twingly/http.rb:66:in `default_logger': uninitialized constant Twingly::HTTP::Client::Logger (NameError) ``` This bug was introduced in #13.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...and add corresponding spec
Close #9