Skip to content

Adjust user_agent creation#31

Merged
yendi127 merged 1 commit intomasterfrom
adjust-user-agent-creation
Nov 6, 2024
Merged

Adjust user_agent creation#31
yendi127 merged 1 commit intomasterfrom
adjust-user-agent-creation

Conversation

@yendi127
Copy link
Contributor

@yendi127 yendi127 commented Nov 6, 2024

This new addition allows the user to set a specific user_agent for the client.

I added a new parameter to the initialize, so that if we'd want to use a specific user_agent it would be possible. This parameter has a default as well, so that no changes would have to be made in older projects unless a specific user_agent is needed.

The specs have also been updated accordingly.

I added a new parameter to the initialize, so that if we'd want to use a specific user_agent it would be possible. This parameter has a default as well, so that no changes would have to be made in older projects unless a specific user_agent is needed.
Copy link
Member

@roback roback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yendi127 yendi127 merged commit 0c419de into master Nov 6, 2024
@yendi127 yendi127 deleted the adjust-user-agent-creation branch November 6, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants