Skip to content

Make sure instance variables are declared in __init__#24

Merged
roback merged 1 commit intomasterfrom
fix/23/fix-instance-var-declaration
Feb 25, 2016
Merged

Make sure instance variables are declared in __init__#24
roback merged 1 commit intomasterfrom
fix/23/fix-instance-var-declaration

Conversation

@roback
Copy link
Member

@roback roback commented Feb 25, 2016

Declaring them directly in the class makes them class variables.

fix #23

@dentarg
Copy link
Contributor

dentarg commented Feb 25, 2016

should we add the tests we talked about? check that the "empty" object has the instance variables we want, or is it too much?

@roback
Copy link
Member Author

roback commented Feb 25, 2016

should we add the tests we talked about? check that the "empty" object has the instance variables we want, or is it too much?

Yes, Im on it :)

@dentarg
Copy link
Contributor

dentarg commented Feb 25, 2016

great :)

@roback
Copy link
Member Author

roback commented Feb 25, 2016

should we add the tests we talked about? check that the "empty" object has the instance variables we want, or is it too much?

Yes, Im on it :)

I think I changed my mind, maby its too much :). The user never sees the "empty" objects themselves. The only object the user should create themselves is the Client.

@dentarg
Copy link
Contributor

dentarg commented Feb 25, 2016

Sure, let's be happy with this. LGTM

roback added a commit that referenced this pull request Feb 25, 2016
Make sure instance variables are declared in __init__
@roback roback merged commit 70cbfab into master Feb 25, 2016
@roback roback deleted the fix/23/fix-instance-var-declaration branch February 25, 2016 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Instance variables not declared correctly

2 participants