Improve time pagination (breaking compatibility for Query#start_time and Query#end_time) #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If all matches has been returned, we have all results.
Previously we @start_time and @end_time would contain pre-formatted strings, making it hard to compare the current set start_time/end_time when paginating. Now we’re formatting just before constructing the url parameters.
* Print post URLs, not blog URLs (do as the filename says) * Implement a class to get all results, showing how time pagination could be done * Use a more refined pattern to avoid paginating through tens of thousands results
Contributor
|
👍 |
jage
added a commit
that referenced
this pull request
Sep 14, 2015
Improve ability to paginate results
jage
changed the title
start_time, end_time and introducing Result#all_results_returned?)
jage
changed the title
start_time, end_time and introducing Result#all_results_returned?)
jage
changed the title
jage
changed the title
jage
changed the title
Query#start_time and Query#end_time)
jage
changed the title
Query#start_time and Query#end_time)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result#all_results_returned?can tell you if you got all results or need to “paginate”start_timeandend_timeobjectsIf merged this will require a version bump before release. Probably a major since
start_timeandend_timeresponse has been altered.