Skip to content

Add YARD documentation comments#32

Merged
roback merged 3 commits intomasterfrom
yard-documentation
Nov 30, 2015
Merged

Add YARD documentation comments#32
roback merged 3 commits intomasterfrom
yard-documentation

Conversation

@roback
Copy link
Copy Markdown
Member

@roback roback commented Nov 27, 2015

Documented all public methods/attributes using http://yardoc.org/

Started a yard server locally by running

bundle exec yard server --reload

Todo

  • Rake task for generating documentation/starting server
  • Update readme
  • Answer the question: "should documentation be checked in or not?"

@roback
Copy link
Copy Markdown
Member Author

roback commented Nov 30, 2015

should documentation be checked in or not?

I have no idea, some keeps it in the repo, some don't.

Im choosing not to as it's one more thing to remember to update each time you make a change. The YARD-comments in the code is still there which should be enough.

@dentarg
Copy link
Copy Markdown
Contributor

dentarg commented Nov 30, 2015

I agree, we should not have the generated documentation in the repo

@dentarg
Copy link
Copy Markdown
Contributor

dentarg commented Nov 30, 2015

👍

@jage
Copy link
Copy Markdown
Contributor

jage commented Nov 30, 2015

Great job! 👍

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can "is not" over "isn't" in our documentation, wdyt?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that looks better.

@walro
Copy link
Copy Markdown
Contributor

walro commented Nov 30, 2015

Awesome work, left a few minor comments

@roback
Copy link
Copy Markdown
Member Author

roback commented Nov 30, 2015

Awesome work, left a few minor comments

"a few" 😛

@walro
Copy link
Copy Markdown
Contributor

walro commented Nov 30, 2015

:) LGTM!

roback added a commit that referenced this pull request Nov 30, 2015
Add YARD documentation comments
@roback roback merged commit e08d7a1 into master Nov 30, 2015
@roback roback deleted the yard-documentation branch November 30, 2015 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants