Skip to content

Quote column names#115

Merged
mithrandi merged 5 commits intomasterfrom
divmod-dev_quote-internal-schema-2770
Aug 26, 2020
Merged

Quote column names#115
mithrandi merged 5 commits intomasterfrom
divmod-dev_quote-internal-schema-2770

Conversation

@mithrandi
Copy link
Contributor

This future-proofs against new keywords.

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #115 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   92.10%   92.05%   -0.05%     
==========================================
  Files         109      109              
  Lines       10674    10674              
  Branches      862      862              
==========================================
- Hits         9831     9826       -5     
- Misses        679      683       +4     
- Partials      164      165       +1     
Impacted Files Coverage Δ
axiom/_schema.py 100.00% <100.00%> (ø)
axiom/store.py 91.77% <100.00%> (ø)
axiom/test/onestepapp.py 94.23% <0.00%> (-3.85%) ⬇️
axiom/test/morenewapp.py 96.55% <0.00%> (-3.45%) ⬇️
axiom/_fincache.py 65.00% <0.00%> (-1.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d680fd...0e3b082. Read the comment docs.

@glyph
Copy link
Member

glyph commented Mar 31, 2020

This is stuck on some CI bugs, but should be landed once we have removed the twtrunk builds (since twisted no longer supports 2.7)

@mithrandi mithrandi merged commit 4ecf1a3 into master Aug 26, 2020
@mithrandi mithrandi deleted the divmod-dev_quote-internal-schema-2770 branch August 26, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants