Skip to content

Conversation

@glyph
Copy link
Member

@glyph glyph commented Jun 1, 2022

fixes #551

also removes python3.6 support from the test matrix because there is a bunch of tedious version-constraint work to do here in order to get it to work, and I don't feel like bothering for a dead-for-half-a-year version of Python: https://endoflife.date/python

@glyph glyph force-pushed the more-updatable-reqs branch from 0b12a84 to 18cf30d Compare June 1, 2022 01:12
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #552 (37338e4) into master (79f9be4) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
+ Coverage   98.86%   99.04%   +0.18%     
==========================================
  Files          44       44              
  Lines        3880     3881       +1     
  Branches      245      357     +112     
==========================================
+ Hits         3836     3844       +8     
+ Misses         30       23       -7     
  Partials       14       14              
Impacted Files Coverage Δ
src/klein/_plating.py 100.00% <ø> (ø)
src/klein/_app.py 100.00% <100.00%> (ø)
src/klein/_resource.py 96.52% <100.00%> (+4.91%) ⬆️
src/klein/test/test_resource.py 98.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79f9be4...37338e4. Read the comment docs.

@glyph glyph marked this pull request as ready for review June 1, 2022 04:34
@glyph glyph requested a review from a team as a code owner June 1, 2022 04:34
@glyph
Copy link
Member Author

glyph commented Jun 1, 2022

@wsanchez @adiroiban CI is completely broken and deps are wildly out of date, so I'm just merging this to unblock everything. I'd love a post-hoc review though, and I'd be happy to make updates to trunk once we're back in a green starting state.

@glyph glyph merged commit 4041169 into master Jun 1, 2022
@glyph glyph deleted the more-updatable-reqs branch June 1, 2022 04:35
@twm
Copy link
Member

twm commented Jun 8, 2022

@glyph The move to .txt files in the requirements directory is for compatibility with some Dependabot heuristic, correct?

@glyph
Copy link
Member Author

glyph commented Jun 8, 2022

@twm Yes. Although it's an idiom that predates dependabot, and it's easier to maintain with tools like pur and requires.io as well, though, so it's not just for Dependabot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

extract requirements from tox.ini

2 participants