Skip to content

Make public_settings and last_update_time nullable in API responses #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Make public_settings and last_update_time nullable in API responses #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00c3053
Initial plan
Copilot Mar 24, 2026
49e2dd7
Fix API changes: make public_settings and last_update_time optional
Copilot Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/api/response/site.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ pub struct Details {
pub alert_severity: Option<String>,
pub uris: Uris,
/// includes if this site is public and its public name
pub public_settings: PublicSettings,
pub public_settings: Option<PublicSettings>,
}

#[derive(Debug, Deserialize)]
Expand Down Expand Up @@ -270,8 +270,8 @@ pub struct PowerData {
#[derive(Debug, Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct Overview {
#[serde(with = "DateTimeSerde")]
pub last_update_time: NaiveDateTime,
#[serde(with = "DateTimeSerdeOpt")]
pub last_update_time: Option<NaiveDateTime>,
#[serde(rename = "lifeTimeData")]
pub lifetime_data: LifetimeData,
pub last_year_data: EnergyData,
Expand Down
Loading