Indicate required content-type for webhook subscription verification#145
Merged
Xemdo merged 1 commit intotwitchdev:mainfrom Mar 25, 2022
Merged
Indicate required content-type for webhook subscription verification#145Xemdo merged 1 commit intotwitchdev:mainfrom
Xemdo merged 1 commit intotwitchdev:mainfrom
Conversation
Since the documentation doesn't tell it (I looked thoroughly, but I might be wrong), I think it's a good idea to tell the user which content-type is awaited when verifying the webhook subscription.
BarryCarlyon
approved these changes
Mar 20, 2022
Xemdo
approved these changes
Mar 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the documentation doesn't tell it (I looked thoroughly, but I might be wrong), I think it's a good idea to tell the user which content-type is awaited when verifying the webhook subscription.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Problem/Feature
The problem I identified (maybe wrongly?) is that it is not specified in the official twitch api documentation which value the Content-Type header should have for the webhook subscription verification. Since I had to look into the source code of this project to get my answer (no hard feelings at all), I think it might be good to indicate to the users of the twitch-cli why their requests are invalid.
Description of Changes:
Checklist